Fix identifier parsing not breaking on the |> pipe operator#2156
Merged
iffyio merged 3 commits intoapache:mainfrom Jan 29, 2026
Merged
Fix identifier parsing not breaking on the |> pipe operator#2156iffyio merged 3 commits intoapache:mainfrom
|> pipe operator#2156iffyio merged 3 commits intoapache:mainfrom
Conversation
|> pipe operator
iffyio
reviewed
Jan 22, 2026
9bff17a to
d52d628
Compare
Contributor
Author
|
Rebased / addressed test format👌 |
f9ea84d to
176852c
Compare
iffyio
reviewed
Jan 26, 2026
22c9e3c to
807acf4
Compare
iffyio
approved these changes
Jan 29, 2026
Contributor
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @alexander-beedie!
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in Pipe SQL parsing with identifiers followed by the
|>operator.Fix
parse_identifiersneeds to break onToken::VerticalBarRightAngleBracketas well, otherwise it continues to consume the following tokens asIdent(until one of the other break conditions is encountered).Example
Without the fix the DROP section consumes the RENAME tokens as identifiers:
After the fix the identifier boundary is respected, and the operations parse correctly:
Also
(one per pipe-operator).